Skip to content

Allow module can-load.php callbacks to return a WP_Error with more information - #891

Merged
felixarntz merged 4 commits into
trunkfrom
update/can-load-infrastructure
Dec 1, 2023
Merged

Allow module can-load.php callbacks to return a WP_Error with more information#891
felixarntz merged 4 commits into
trunkfrom
update/can-load-infrastructure

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Nov 30, 2023

Copy link
Copy Markdown
Member

Summary

Followup work discussed here: #885 (comment)

This PR updates can load infrastructure so that it will support the custom message.

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure no milestone PRs that do not have a defined milestone for release Miscellaneous Issues not related to an existing focus area labels Nov 30, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Nov 30, 2023
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review November 30, 2023 09:47
swissspidy
swissspidy reviewed Nov 30, 2023
View reviewed changes
Comment thread load.php Outdated
swissspidy
swissspidy reviewed Nov 30, 2023
View reviewed changes
Comment thread load.php Outdated
swissspidy
swissspidy reviewed Nov 30, 2023
View reviewed changes
Comment thread admin/load.php Outdated
@mukeshpanchal27 @swissspidy
Apply suggestions from code review
493a28f 
Co-authored-by: Pascal Birchler <pascalb@google.com>
swissspidy